Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/issue 1064 restore spa fallback handling for client side routing #1065

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 15, 2023

Related Issue

resolves #1064

Summary of Changes

  1. Restore standard SPA fallback handling for client side routing
  2. Add test cases to cover these regressions

TODO

  1. Do we not have a test case for this?

@thescientist13 thescientist13 added bug Something isn't working CLI labels Feb 15, 2023
@thescientist13 thescientist13 changed the base branch from master to release/0.28.0 February 15, 2023 02:25
@thescientist13 thescientist13 force-pushed the bug/issue-1064-broken-SPA-fallback-handling branch from 4001fc6 to 2093da4 Compare February 15, 2023 02:28
@thescientist13 thescientist13 linked an issue Feb 15, 2023 that may be closed by this pull request
@thescientist13 thescientist13 self-assigned this Feb 15, 2023
@thescientist13 thescientist13 force-pushed the bug/issue-1064-broken-SPA-fallback-handling branch from 869840c to d446bd1 Compare February 18, 2023 18:52
Copy link
Member Author

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In light of #1070 , just wanted to capture that after a rebase, all the specs are at least passing locally

  2579 passing (5m)
  28 pending

@thescientist13 thescientist13 merged commit cb62091 into release/0.28.0 Feb 18, 2023
@thescientist13 thescientist13 deleted the bug/issue-1064-broken-SPA-fallback-handling branch February 18, 2023 19:06
thescientist13 added a commit that referenced this pull request Apr 9, 2023
…1065)

* restore SPA fallback handling for client side rendering

* add test cases to cover regressions
thescientist13 added a commit that referenced this pull request Apr 9, 2023
…1065)

* restore SPA fallback handling for client side rendering

* add test cases to cover regressions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPA fallback handling not working (v0.28.0-alpha.1)
1 participant