Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/issue 1004 document latest status for non standard import formats #1166

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Oct 16, 2023

Related Issue

"resolves" #1004

It seems coming out of #952 , using import even with .gql files seems to be working just fine, and since this also works with JSX as evidenced in our test cases, I think this means everything is now compatible!

  • .json
  • .css
  • .gql
  • .jsx
  • .ts *

There is a scenario in which we need to handle TypeScript (or any general form of non-standard JavaScript) in WCC - ProjectEvergreen/wcc#122

Summary of Changes

  1. Update documentation (and test case comment) to clarify latest state of custom loaders and configuration
  2. Add placeholder TypeScript <> WCC test case

Not sure what the specific fix was, but possibly as part #1151 ?

@thescientist13 thescientist13 added the documentation Greenwood specific docs label Oct 16, 2023
@@ -217,7 +217,7 @@ console.log(json); // { status: 200, message: 'some data' }
```

**Steps**
1. Make sure you are using Node `v18.12.1`
1. Make sure you are using Node `v18.15.0`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, 18.12.1 I think still works? So maybe this doesn't need to specifically called out 🤷

@thescientist13 thescientist13 merged commit 45facc4 into release/0.29.0 Oct 27, 2023
7 of 8 checks passed
@thescientist13 thescientist13 deleted the docs/issue-1004-document-non-standard-import-formats branch October 27, 2023 13:28
thescientist13 added a commit that referenced this pull request Nov 9, 2023
#1166)

* update documentation around custom imports

* update test case descriptions and add placeholder prerender typescript test case

* update test case descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Greenwood specific docs
Projects
None yet
1 participant