Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/ensure minimum compatible version of wcc 0.12.1 #1209

Merged

Conversation

thescientist13
Copy link
Member

Related Issue

As part of the v0.30.0-alpha.0 release, WCC was upgrade to v0.12.0 and in that change, this error was discovered upgrading the following three repos.

➜  greenwood-demo-adapter-vercel git:(chore/upgrade-greenwood-0.30.0) ✗ npm run dev

> greenwood-demo-adapter-vercel@1.0.0 dev
> greenwood develop

-------------------------------------------------------
Welcome to Greenwood (v0.30.0-alpha.0) ♻️
-------------------------------------------------------
Initializing project config
Initializing project workspace contexts
Generating graph of workspace files...
building from local sources...

node:internal/process/promises:288
            triggerUncaughtException(err, true /* fromPromise */);
            ^
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'acorn-jsx' imported from /Users/owenbuckley/Workspace/project-evergreen/greenwood-demo-adapter-vercel/node_modules/wc-compiler/src/jsx-loader.js
    at new NodeError (node:internal/errors:393:5)
    at packageResolve (node:internal/modules/esm/resolve:860:9)
    at moduleResolve (node:internal/modules/esm/resolve:909:20)
    at defaultResolve (node:internal/modules/esm/resolve:1124:11)
    at nextResolve (node:internal/modules/esm/loader:163:28)
    at ESMLoader.resolve (node:internal/modules/esm/loader:841:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:18)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:76:40)
    at link (node:internal/modules/esm/module_job:75:36) {
  code: 'ERR_MODULE_NOT_FOUND'

Summary of Changes

  1. Any new users should be fine and / or can override, but this at least ensures the minimum compatible version in Greenwood to v0.12.1

@thescientist13 thescientist13 added bug Something isn't working Plugins Greenwood Plugins CLI SSR labels Mar 10, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Mar 10, 2024
@thescientist13 thescientist13 merged commit 8b91f80 into release/0.30.0 Mar 16, 2024
8 checks passed
@thescientist13 thescientist13 deleted the bug/ensure-minimum-capatible-version-wcc-0.12.1 branch March 16, 2024 23:13
@thescientist13 thescientist13 mentioned this pull request Mar 16, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.1 bug Something isn't working CLI Plugins Greenwood Plugins SSR v0.30.0
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant