Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Sitemap Copy Plugin (#1232) #1245

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/plugin-dynamic-sitemap/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# @greenwood/plugin-dynamic-sitemap

## Overview
Spiders love to spider. To show our love to all the spiders out there, this plugin reads
the graph and renders a sitemap.xml. Currently, it handles up to 10000 content entries, warning
after 9000 content entries.

## Usage
Add this plugin to your _greenwood.config.js_ and spread the `export`.

```javascript
import { greenwoodPluginDynamicExport } from '@greenwood/plugin-dynamic-sitemap';

export default {
...

plugins: [
greenwoodPluginDynamicExport({
"baseUrl": "https://example.com"
})
]
}
```

30 changes: 30 additions & 0 deletions packages/plugin-dynamic-sitemap/src/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import fs from 'fs/promises';

const greenwoodPluginDynamicExport = (options = {}) => [{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting approach and maybe it's just something I'm missing here but the main concern / limitation I see with this approach is that there is no way to programmatically build your own sitemap. To me, the advantage of the dynamic sitemap option was that could automatically build it up whatever way you need, even tapping into your own frontmatter / page metadata.

Referencing my back of the napkin example in #1232, which is basically just taking a page out of the Next.js playbook, I would expect users to be able to make a sitemap.xml.(js|ts) file in the root of their workspace (e.g. src/sitemap.xml.js, which would just export a function in which we pass the compilation to them, and they can build it up themselves and set their own values for all supported properties, since there are things they might want

export async function sitemap(compilation) {
  const urls = compilation.graph.map((page) => {
    const { data, route } = route;

    return `
      <url>
        <loc>http://www.example.com${page.route}</loc>
        <changefreq>${data.freq}</changefreq>
        <priority>https://www.sitemaps.org/protocol.html#prioritydef>${data.priority ?? '1.0'}</priority>
      </url>
    `;
  });
  const sitemap = `
    <?xml version="1.0" encoding="UTF-8"?>
    <urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
      ${urls.join('\n')}
    </urlset>
  `;

  return new Response(body, { headers: 'Content-Type' : 'text/xml' })
}

As far as how to do this through greenwood, I think the API Resource as a reference is probably going to get us halfway there at least for development, such that hitting https://localhost:1984/sitemap.xml returns something.

For build time, we maybe add something to the build step like we do for adapters, where if we have a sitemap (perhaps the graph can track this on init?) we import the that function from the user's file and write out the file for them?

type: 'copy',
name: 'plugin-dynamic-sitemap',
provider: async (compilation) => {

const { baseUrl } = options;
const { outputDir } = compilation.context;

let sitemapXML = '<?xml version="1.0" encoding="UTF-8"?>\n';
sitemapXML += '<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">\n';

compilation.graph.forEach(page => {
sitemapXML += `<url><loc>${baseUrl}${page.outputPath}</loc></url>\n`;
});

sitemapXML += '</urlset>';

const sitemapUrl = new URL('./sitemap.xml', outputDir);
await fs.writeFile(sitemapUrl, sitemapXML);

return {
from: sitemapUrl,
to: new URL('./sitemap.xml', outputDir)
};
}
}];

export { greenwoodPluginDynamicExport };
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
/*
* Use Case
* Run Greenwood build command with no config and this plugin.
*
* User Result
* Should generate a bare bones Greenwood build with correctly built sitemap.xml
*
* User Command
* greenwood build
*
* User Config
* import { greenwoodPluginDynamicExport } from '@greenwood/plugin-dynamic-sitemap';
*
* {
* plugins: [{
* greenwoodPluginDynamicExport({
* "baseUrl": "https://example.com"
* })
* }]
*
* }
*
* User Workspace
* src/
* templates/
* artist.html
* pages/
* index.md
* about.md
*/

import fs from 'fs';
import path from 'path';
import { runSmokeTest } from '../../../test/smoke-test.js';
import { getSetupFiles, getOutputTeardownFiles } from '../../../test/utils.js';
import { Runner } from 'gallinago';
import { fileURLToPath, URL } from 'url';

describe('Build Greenwood With Dynamic Sitemap Plugin: ', function() {
const LABEL = 'Using Dynamic Sitemap feature';
const cliPath = path.join(process.cwd(), 'packages/cli/src/index.js');
const outputPath = fileURLToPath(new URL('.', import.meta.url));
let runner;

before(function() {
this.context = {
publicDir: path.join(outputPath, 'public')
};
runner = new Runner();
});

describe(LABEL, function() {

before(function() {
runner.setup(outputPath, getSetupFiles(outputPath));
runner.runCommand(cliPath, 'build');
});

runSmokeTest(['public', 'index'], LABEL);

describe('Sitemap.xml should exist and be well formed', function() {

it('should have one sitemaps file in the output directory', function() {
const sitemapXML = fs.readFileSync(path.join(this.context.publicDir, './sitemap.xml'));
console.log(sitemapXML);
});
});

});

after(function() {
runner.teardown(getOutputTeardownFiles(outputPath));
});
});
10 changes: 10 additions & 0 deletions packages/plugin-dynamic-sitemap/test/greenwood.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import { greenwoodPluginDynamicExport } from '../src/index.js';

console.log(greenwoodPluginDynamicExport);
export default {
plugins: [
...greenwoodPluginDynamicExport({
'baseUrl': 'https://example.com'
})
]
};
4 changes: 4 additions & 0 deletions packages/plugin-dynamic-sitemap/test/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"version": "1.0.0",
"type": "module"
}
3 changes: 3 additions & 0 deletions packages/plugin-dynamic-sitemap/test/src/pages/about.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# About Us

Lorem ipsum.
3 changes: 3 additions & 0 deletions packages/plugin-dynamic-sitemap/test/src/pages/index.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## Home Page

Welcome!
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<html>

<body>
<h1>Welcome to the artist page.</h1>
<content-outlet></content-outlet>
</body>

</html>
Loading