Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/issue 426 restore userland postcss #453

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 23, 2020

Related Issue

resolves (part of) #426

This PR is just focusing on PostCSS support for now. Another PR(s) will come for Babel and Browserslist

Summary of Changes

  1. Restored userland PostCSS configuration in Rollup and CSS Tranforms
  2. Add projectDirectory to compilation.context for convenience
  3. Restored nested CSS for all www/styles/ and www/components/
  4. Re-enabled PostCSS test cases
  5. Updated Build configuration section of the docs to demonstrate new behavior

Notes / TODOs

  1. Update documentation - wait for Docs/issue 430 update technical documentation to reflect current project status #452 to be merged first? (then should be able to use context too in the transform?)
  2. Should we consider extending this support to <style> tags too? (as another issue at least) - tracked in Trello for post 1.0 tracking
  3. Probably also for another issue, but right now we have to process everything twice to support the user's PostCSS (once in serve and again in bundle / rollup since we read from file, not the server) . It would be nice if Rollup could start from the processed output of the serve lifecycle so we don't have to re-run userland PostCSS again. - added to Roadmap To 1.0 And Beyond #418
  4. Noticed that the CSS puppeteer (and whitespace from us?) puts into an index.html page is almost 10KB!!! This may be causing style collisions colliding with styles 👆 ? Either way, we should control the HTML output. If want to support inlining CSS great, but then we also shouldn't ship it over the network either. One or the other. Will make an issue to track this specific issue of junk in the trunk, and another to track optimizing for inlining CSS. - added to Roadmap To 1.0 And Beyond #418
view-source:https://deploy-preview-436--elastic-blackwell-3aef44.netlify.app/

Screen Shot 2020-12-23 at 1 54 29 PM

Screen Shot 2020-12-23 at 1 00 33 PM

After deleting all that....
Screen Shot 2020-12-23 at 1 01 21 PM

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) CLI labels Dec 23, 2020
@thescientist13 thescientist13 linked an issue Dec 23, 2020 that may be closed by this pull request
7 tasks
@thescientist13 thescientist13 mentioned this pull request Dec 24, 2020
53 tasks
@thescientist13 thescientist13 self-assigned this Dec 24, 2020
@thescientist13 thescientist13 added the documentation Greenwood specific docs label Dec 28, 2020
@thescientist13 thescientist13 force-pushed the enhancement/issue-426-restore-userland-postcss branch from 8e9dee4 to 61bd2e0 Compare December 30, 2020 16:45
@thescientist13 thescientist13 merged commit 5d97a05 into release/0.10.0 Dec 30, 2020
@thescientist13 thescientist13 deleted the enhancement/issue-426-restore-userland-postcss branch December 30, 2020 16:55
thescientist13 added a commit that referenced this pull request Apr 3, 2021
* user postcss plugins for production

* userland postcss from css transform

* restore nested styles for components

* renable and update PostCSS test case

* reference projectDirectory context in rollup

* update build docs for PostCSS configuration

* fix link
thescientist13 added a commit that referenced this pull request Apr 3, 2021
* user postcss plugins for production

* userland postcss from css transform

* restore nested styles for components

* renable and update PostCSS test case

* reference projectDirectory context in rollup

* update build docs for PostCSS configuration

* fix link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restore Babel / PostCSS / Browserslist for no bundle development
1 participant