Enhancement/issue 426 plugin babel #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
enhancement
7 tasks
thescientist13
commented
Feb 28, 2021
greenwood.config.js
Outdated
| ...pluginBabel({ | ||
| mergeConfigs: true | ||
| }), | ||
| ...pluginCommonJs(), |
There was a problem hiding this comment.
Will try and remove the need for this this through better exportMap handling
thescientist13
force-pushed
the
enhancement/issue-426-plugin-babel
branch
from
dd29716
to
952905f
Compare
thescientist13
added a commit
that referenced
this pull request
Apr 3, 2021
* initial example of a babel plugin * babel working with babel * ignore test file * set default value for babelHelpers * set peer deps for plugin-postcss and plugin-babel * WIP babel preset env * babel preset env working * add default test case * minor cleanup * minor cleanup * extendConfig refactoring and specs * improve export map detection and force ESM support from Babel * test cases and refactoring for postcss * config look refactor * enable preset env for postcss and update docs * grammar * grammar and punctuation * delete obsolete test case * restore eject command and specs and docs * remove example code from www
thescientist13
added a commit
that referenced
this pull request
Apr 3, 2021
* initial example of a babel plugin * babel working with babel * ignore test file * set default value for babelHelpers * set peer deps for plugin-postcss and plugin-babel * WIP babel preset env * babel preset env working * add default test case * minor cleanup * minor cleanup * extendConfig refactoring and specs * improve export map detection and force ESM support from Babel * test cases and refactoring for postcss * config look refactor * enable preset env for postcss and update docs * grammar * grammar and punctuation * delete obsolete test case * restore eject command and specs and docs * remove example code from www
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #426 (finally!)
Summary of Changes
exportMaphandling in plugin-node-modulespeerDependencyfor plugin-postcss and plugin-babelejectfunctionalityDemo code using
#privatemembers running via branch previewTODO
BabelQuestions / Thoughts
Do we still need an
ejectfeature at this point as now all but our (equivalent) webpack configuration is gone from the project and is being moved to plugins, and I would honestly prefer not to couple so tightly to any particular technology (e.g. Rollup). I think the Rollup plugin API is actually a leaky abstraction but I recognize can be a useful escape hatch. However, if I can find a way to reuse something likeResourceInterface.interceptduring build time instead, I might consider deprecating the Rollup plugin API, or at least dropping support foreject.