Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 14x minimum version #721

Merged
merged 3 commits into from
Dec 9, 2021

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Sep 10, 2021

Related Issue

N / A

Summary of Changes

Not sure why master branch failed but our CI didn't fail for the same PR, but figured that since Node 12 is in maintenance mode and will be unsupported soon, can't hurt to align this now and see if it stabilizes things.
Screen Shot 2021-09-10 at 4 20 59 PM

TODO

  1. Get things passing
  2. Make an issue to track this deprecation as a good first issue seen in the test logs - no longer in the codebase
    Build Greenwood With: 
    (node:5249) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead

Screen Shot 2021-09-10 at 6 07 43 PM

@thescientist13
Copy link
Member Author

Hmm, seems this is broken here, but ode 12 is still working again, so no rush on this then, going to move to draft.

@thescientist13 thescientist13 changed the base branch from master to release/0.20.0 December 6, 2021 15:30
@thescientist13 thescientist13 marked this pull request as ready for review December 6, 2021 15:35
@thescientist13 thescientist13 moved this from IN PROGRESS to IN REVIEW in 7 - SSR and External Data Sources Dec 6, 2021
Copy link
Member

@hutchgrant hutchgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thescientist13 thescientist13 merged commit 9cf58e7 into release/0.20.0 Dec 9, 2021
@thescientist13 thescientist13 deleted the chore/adjust-ci-node-versions branch December 9, 2021 15:34
@thescientist13 thescientist13 moved this from IN REVIEW to DONE in 7 - SSR and External Data Sources Dec 9, 2021
thescientist13 added a commit that referenced this pull request Dec 9, 2021
* align nodejs versions

* update version

* update and rebase with release branch
thescientist13 added a commit that referenced this pull request Dec 18, 2021
* align nodejs versions

* update version

* update and rebase with release branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.1 breaking chore unit testing, maintenance, etc CLI v0.20.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants