Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 954 puppeteer plugin #960

Merged
merged 23 commits into from Jul 16, 2022

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jul 10, 2022

Related Issue

resolves #954

Summary of Changes

  1. Moved puppeteer to be a (customUrl) based prerender only plugin package
  2. Made WCC default prerenderer
  3. Upgraded puppeteer version
  4. Updated tests cases that depended directly on prerendering (had to bump coverage down due to 1% drop)
  5. Update site documentation accordingly

Note: there will be some lingering cross dependencies for GraphQL and Import Plugins on Puppeteer plugin for pre-rendering support until #878 / #952 have been addressed

TODO

  1. Fix Windows specs (index pages not rendering)
  2. former JS <> HTML inline prerender dependent specs not working now? (see xit in puppeteer plugin)
  3. Documentation (website / package README)
  4. Sweep CLI / Puppeteer package.json file for accuracy
  5. Upgrade to latest versions of WCC
  6. Plugin Import JSON export is wrong (also fix spellings of Uaer and @greenwod) - need to make an issue - Import CommonJS plugin named export is spelled wrong 🤦 #961
  7. preRenderCompilationWorker should / could run as a Promise.all?

Questions / Backlog Tracking

@thescientist13 thescientist13 added documentation Greenwood specific docs Plugins Greenwood Plugins CLI breaking SSR feature New feature or request labels Jul 10, 2022
@thescientist13 thescientist13 linked an issue Jul 11, 2022 that may be closed by this pull request
9 tasks
@thescientist13
Copy link
Member Author

thescientist13 commented Jul 11, 2022

What's odd about the windows failure is that it the Puppeteer rendering is only broken for the home page (/ route). For example, running the serve task on Windows will exhibit the failing test cases on the home page, but About and all other pages work fine. (notice the <app-header>) 😕 🤔

Home Page
Screen Shot 2022-07-11 at 9 09 11 AM

Getting Started
Screen Shot 2022-07-11 at 9 09 41 AM

Some thoughts off the top of my head

  • A race condition given it is the first page? Maybe I can verify if the graph.json file for it gets made correctly
  • Something about paths / routes on Windows? / vs \
  • Delete and downgrade Puppeteer version

@thescientist13 thescientist13 self-assigned this Jul 11, 2022
@thescientist13 thescientist13 marked this pull request as ready for review July 13, 2022 01:55
@thescientist13 thescientist13 merged commit aa4d2f4 into release/0.26.0 Jul 16, 2022
@thescientist13 thescientist13 deleted the feature/issue-954-puppeteer-plugin branch July 16, 2022 15:50
thescientist13 added a commit that referenced this pull request Jul 27, 2022
* puppeteer renderer plugin and migrate resource plugin

* introduce custom function option for renderer plugins and moved puppeteer logic into plugin

* made WCC default prerender

* stabilize specs

* upgrade latest version of puppeteer

* add specs for puppeteer renderer plugin

* clarify it block

* stablize all CLI specs

* fix spelling mistake

* comments for init specs

* restore graphql specs with dependency on puppeteer plugin when prerendering

* restore all specs and adjust thresholds

* misc PR cleanup

* fix lint and clean up package jsons

* fix lint and clean up package jsons

* upgrade latest version of WCC

* update docs to reflect prerendering with WCC and cross dependencies with Puppeteer

* fix and restore puppeteer based inline javascript execution specs

* fix typo in specs

* cross platform puppeteer intercepting support

* refactor preRenderCompilationWorker to be async Promise.all
@thescientist13 thescientist13 added the dependencies Pull requests that update a dependency file label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking CLI dependencies Pull requests that update a dependency file documentation Greenwood specific docs feature New feature or request Plugins Greenwood Plugins SSR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

puppeteer based renderer plugin and HTMLElement (WCC) as default renderer
1 participant