Fixing form submit, resolves #14 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey @hutchgrant .
Is it possible to undo the formatting only related changes? For reviewing a PR it makes it a bit harder to just see the specific changes for the fix / change itself.
Ideally some sort of tool would keep this all in line, but for this project, as an example, doesn't really have that yet. But if something like prettier were to be added, I think it would be best to add it and format all the files in its own PR.
hutchgrant
added a commit
that referenced
this pull request
Nov 8, 2018
thescientist13
pushed a commit
that referenced
this pull request
Nov 10, 2018
There was a problem hiding this comment.
@hutchgrant
In addition to undoing formatting, you will want to rebase your PR here against the latest changes just merged into master.
|
@hutchgrant |
hutchgrant
force-pushed
the
form-submit-fix
branch
from
d726c95
to
897127f
Compare
hutchgrant
force-pushed
the
form-submit-fix
branch
from
897127f
to
0fe6e6c
Compare
thescientist13
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent form from reloading the page on enter.