Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header Component #26

Closed
7 tasks done
thescientist13 opened this issue Apr 7, 2024 · 1 comment · Fixed by #44
Closed
7 tasks done

Header Component #26

thescientist13 opened this issue Apr 7, 2024 · 1 comment · Fixed by #44
Assignees
@Auhseh
Labels
documentation Improvements or additions to developer documentation enhancement New feature or request good first issue Good for newcomers
Milestone
Website Redesign ...

Comments

@thescientist13
Copy link
Member

thescientist13 commented Apr 7, 2024 •
edited
Loading

Summary

Will want to create a component for the global site header, with logo on the left and links / socials on the right. Needs to be done after #23

Needs to be done after #23

Screenshot 2024-04-17 at 9 16 05 PM
Screenshot 2024-04-17 at 9 16 13 PM
Screenshot 2024-04-17 at 9 16 17 PM

Details

  1. Will need a src/components/header/header.js component file
  2. Will want a Storybook file
  3. Will want a spec file to test basic content output
  4. Since this one is interactive on mobile breakpoints, we should use declarative shadow DOM in our implementation
  5. (nice to have) what could be a JavaScript disabled fallback for this look like?

Open Items

  1. Need a canonical figma file / screenshot for reference here
    • Figma shows different treatments for home page vs docs / guides pages
    • Need social links in the header - Twitter, GitHub, Discord
    • Social links and logs disappear in mobile?
  2. Will need / want the social and project logos as SVGs - hoping to get them all in feature/issue 23 Styleguide and Design System #36
@thescientist13 thescientist13 added documentation Improvements or additions to developer documentation enhancement New feature or request invalid This doesn't seem right labels Apr 7, 2024
@thescientist13 thescientist13 added the good first issue Good for newcomers label Apr 7, 2024
@thescientist13 thescientist13 self-assigned this Apr 8, 2024
@thescientist13 thescientist13 removed the good first issue Good for newcomers label Apr 8, 2024
This was referenced Apr 8, 2024
Open
Open
Closed
@thescientist13 thescientist13 removed their assignment Apr 30, 2024
@thescientist13 thescientist13 added good first issue Good for newcomers and removed invalid This doesn't seem right labels May 3, 2024
@thescientist13
Copy link
Member Author

Some references

@thescientist13 thescientist13 linked a pull request May 12, 2024 that will close this issue
feature/issue 26 header component #44
Merged
13 tasks
This was referenced May 12, 2024
Merged
Closed
Open
Merged
@thescientist13 thescientist13 mentioned this issue May 22, 2024
Draft
13 tasks
@thescientist13 thescientist13 mentioned this issue May 25, 2024
Merged
@thescientist13 thescientist13 mentioned this issue Jun 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Auhseh Auhseh

Labels
documentation Improvements or additions to developer documentation enhancement New feature or request good first issue Good for newcomers
Projects
[Greenwood] Website Redesign and Relaunch
Status: ✅ Done
Milestone
Website Redesign and Relaunch
Development

Successfully merging a pull request may close this issue.

feature/issue 26 header component ProjectEvergreen/www.greenwoodjs.dev
2 participants
@thescientist13 @Auhseh