Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a shared layout for all pages #32

Closed
1 of 8 tasks
thescientist13 opened this issue Apr 8, 2024 · 3 comments · Fixed by #56
Closed
1 of 8 tasks

create a shared layout for all pages #32

thescientist13 opened this issue Apr 8, 2024 · 3 comments · Fixed by #56
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right

Comments

@thescientist13
Copy link
Member

thescientist13 commented Apr 8, 2024

Summary

We will have a common layout for all pages that will need to include the theme CSS, footer, header, etc.

Depends on #23 , #26, #27

Summary

  1. Create a src/templates/app.html
  2. Should incorporate the theme.css file for all design system branding
  3. Should include the common header component
  4. Should have a <page-outlet></page-outlet> placeholder for all pages content
  5. Should include the common footer component
  6. Should have all <meta> tags from the current website

Open Items

  1. Depends on Styleguide and Design System #23 , Header Component #26, and Footer Component #27
  2. (nice to have) Grid lines / graph paper aesthetic - create a shared layout for all pages #32 (comment) - nvm, this is only on the Home Page #30
@thescientist13 thescientist13 added enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right labels Apr 8, 2024
@thescientist13 thescientist13 changed the title shared layout for all pages create a shared layout for all pages Apr 8, 2024
@thescientist13 thescientist13 pinned this issue Apr 8, 2024
@thescientist13 thescientist13 unpinned this issue May 3, 2024
@thescientist13 thescientist13 removed the invalid This doesn't seem right label May 3, 2024
@thescientist13
Copy link
Member Author

@Auhseh
Had a question coming out of #44 where-in I wanted make sure as part of this ticket we account for the "grid lines" / graph paper aesthetic in our design, because I'm not actually sure if that's just part of Figma, or if its actually meant to be part of our designs?
Screenshot 2024-05-17 at 3 03 24 PM

If it is part of our design, it does feel / look similar to the Vercel and Next home pages, so not sure if that was intentional or not.
Screenshot 2024-05-17 at 3 06 17 PM
Screenshot 2024-05-17 at 3 06 26 PM

I don't feel too strongly about it, but in particular if it's already part of someone elee's design, I would prefer not to use it.

@thescientist13 thescientist13 added the question Further information is requested label May 17, 2024
@Auhseh
Copy link
Contributor

Auhseh commented Jun 1, 2024

Just seeing this…. it’s part of the design
It’s actually closer to Cal than Vercel/Next. (Adds a little oomph to the design)

But I totally understand you 🥲

@thescientist13
Copy link
Member Author

No worries, we can evaluate at the time of working on this particular task how we feel about it based on if it's much effort or not to achieve.

@thescientist13 thescientist13 self-assigned this Jun 6, 2024
@thescientist13 thescientist13 added invalid This doesn't seem right and removed question Further information is requested labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right
Projects
Development

Successfully merging a pull request may close this issue.

2 participants