Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TogglePassivesWithAllBending config option does not work #1288

Closed
StrangeOne101 opened this issue Apr 11, 2023 · 1 comment
Closed

TogglePassivesWithAllBending config option does not work #1288

StrangeOne101 opened this issue Apr 11, 2023 · 1 comment

Comments

@StrangeOne101
Copy link
Member

Description

The config option Properties.TogglePassivesWithAllBending does not function. It defaults to true, and when setting to false, toggling bending with /b toggle toggles passives as well. Tested with airbending.

What should happen

Using /b toggle when Properties.TogglePassivesWithAllBending is set to false will not toggle passives. Doing /b toggle passives will still toggle them like it should

ChristopherWMM pushed a commit that referenced this issue May 1, 2024
# Fixes
- Fixed Flight not checking perms for the different slot abilities
- Fixed the cooldown command not respecting permissions
- Fixed short_grass material on 1.20.3+
- Fixed illumination digging into the ground in 1.16
- Fixed bending damage that bypasses armor not bypassing protection enchantments
- Fixed TempArmor duping things
- Fixed waterbending ice suffocating players (#1309)
- Fixed IceSpike and IceBlast working when the source is removed before you click
- Fixed Multiability slots not updating when they start/end
- Fixed Extraction turning deepslate ores into stone when used
- Fixed MythicLib causing you to use abilities when mobs are hit
- Fixed passives being toggled with bending when Properties.TogglePassivesWithAllBending is disabled (#1288)
- Fixed attributes not being updated after the ability starts
- Fixed custom elements that aren't build right causing crashes due to their lack of name
- Fixed TempBlocks attempting to revert in unloaded worlds (#1319)
- Fixed Citizen NPCs causing errors due to no BendingPlayer existing

# Changes
- Optimized AirBlast putting out fire or triggering redstone related blocks. It now does it for every block along the path, and not just every single tick at the current location (so it would miss 33% of blocks)
- Made the database commit all uncommitted changes when the connection is closed
- Optimized TempBlock reverting
  - Reduced the lags caused from TempBlocks reverting. The main cause was due to removing blocks going through the entire queue to find the block to remove, when it could have just been removed from the top.
  - Additionally, there is no longer checks to see if it is already in the queue in some instances. This also caused a lot of pointless CPU processing
@StrangeOne101
Copy link
Member Author

Fixed in 1.11.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant