EarthPillars, Combo Refactor, Various Fixes #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…va 7 Travis check
## Fixes
* Fixes Combos and possibly Passives appearing in `/pk b <Ability>` auto-tabbing.
> * https://trello.com/c/oUg7QRgl/862-combos-are-still-in-b-b-auto-tabbing
* Fixes Combos not loading properly on certain servers.
> * https://trello.com/c/IRysuejG/861-combos-are-attempted-to-be-loaded-incorrectly-causing-them-to-not-be-registered
* Updates PreciousStones to the latest version and resolves API change issues.
> * https://trello.com/c/VWeTHJ9k/860-precious-stones-is-outdated-causes-bending-to-fail-if-it-is-installed
## Removals
* Removes Java 7 Travis jdk check.
## Additions
* Adds "Contributing" section to the `README` to help guide active community members.
* Adds more detail to the `PULL_REQUEST_TEMPLATE` to allow for more uniform pull requests.
* Adds many new blocks to our ability block interaction.
## Fixes
* Fixes default `RapidPunch` damage not being high enough to register as actual damage due to rounding.
> * https://trello.com/c/S0ACcCVE/864-change-rapidpunchs-damage-from-1-to-2-in-default-config
## API Changes
* Updates to `Spigot 1.12.1`.
* Confirmed to be backward compatible with `Spigot 1.12` and `Spigot 1.11.2`.
> * https://trello.com/c/iom3vYQe/859-mc-1121-release
* Renames `ElementalAbility#getTransparentMaterial()` to `ElementalAbility#getTransparentMaterials()`.
* Converted most `byte`/`int` dependent `Material` logic to use `Material` instead.
* `ElementalAbility#getTransparentMaterialSet()` now returns a `HashSet<Material>` instead of a `HashSet<Byte>`.
* `ElementalAbility#getTransparentMaterials()` and `GeneralMethods.NON_OPAQUE` now return `Material[]` instead of `Integer[]`.
* `GeneralMethods#getTargetedLocation()` now takes a `varargs Material[]` instead of a `varargs Integer[]`.
* Removes `ElementalAbility.TRANSPARENT_MATERIAL`. It was outdated and became irrelevent after `GeneralMethods.NON_OPAQUE` was updated.
## Additions * Adds check to combo collisions to discard dead entities.
* Makes chiblocking abilities work on all entities * Fixes chiblock chance * Sets RapidPunch damage back to 1 and fixed the ability * Fixes possible issue in PKListener#onPlayerInteraction()
## Additions
* Adds exception handling to the configurable `Sound` options to prevent `IllegalArgumentExcpetions`.
> * https://trello.com/c/ePnrGrCw/867-add-exception-handling-to-sound-configuration
## Fixes
* Fixes `Earth.LavaSound`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
Fixes
Misc. Changes