Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed EarthTunnel bug #860

Merged
merged 1 commit into from
Oct 28, 2017
Merged

Fixed EarthTunnel bug #860

merged 1 commit into from
Oct 28, 2017

Conversation

jayoevans
Copy link
Contributor

Fixes

  • EarthTunnel bug
    • https://trello.com/c/O1zvQT0N/831-earthtunnel-cant-be-used-on-gravel-sand-red-sand-blocks-that-are-fell
      This bug was caused by blocks with gravity (sand, gravel, etc) falling into already existing TempBlocks and attempting to use EarthTunnel on these blocks. Previously it would result in nothing happening, and the block would be stuck.
      This issue was caused by TempBlock not correctly checking the material type (and data!) of the already existing TempBlock when attempting to create a new instance on a pre-existing TempBlock.
      This was fixed by instead of checking if newtype and newdata on the old and new TempBlock are different, it checks the actual type of the block by using temp.block.getType(), to get the actual values. This is because the already created TempBlock has the same type as what is trying to be set (air), and so the code to set the type again never is called.

@ChristopherWMM ChristopherWMM merged commit 68677d1 into ProjectKorra:wip Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants