Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed JsonProperty to be taken from individual members. #101

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

k163377
Copy link
Contributor

@k163377 k163377 commented Apr 28, 2023

For example, because the annotations given to the getter affected the parameters.

related to FasterXML/jackson-module-kotlin#668

this::_findAnnotation returned incorrect results because it retrieves from all annotations: parameters, fields, and accessors.
@k163377 k163377 merged commit 152c35f into develop Apr 28, 2023
@k163377 k163377 deleted the fix-required branch April 28, 2023 12:15
@cowtowncoder
Copy link

I am not super fluent in Kotlin, but if the idea is that AnnotationIntrospector will try to figure out precedence and merging across different accessors, this is against design of Jackson's annotation handling. Ideally merging would be done in centralized place (POJOPropertiesCollector etc), and not for every annotation separately, and definitely not in AnnotationIntrospector (since they need to be kept relatively simple, and with ability to chain multiple implementations).

I realize handling like this may be the only way to right now solve the specific issue, but doing that will make maintenance much harder, implementation more complicated etc.

@k163377
Copy link
Contributor Author

k163377 commented May 3, 2023

I understand about the policy as jackson, I will revert this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants