Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete dropdown on click searches for typed term not suggested term #3208

Closed
AndrewZachWood opened this issue Jul 9, 2020 · 5 comments · Fixed by #3211
Closed

Autocomplete dropdown on click searches for typed term not suggested term #3208

AndrewZachWood opened this issue Jul 9, 2020 · 5 comments · Fixed by #3211

Comments

@AndrewZachWood
Copy link

Version: "mirador": "3.0.0-beta.10"
Hello! I noticed while setting up my autocomplete service for my instance of Mirador that when I click on a suggested term Mirador sends off a request for the typed term and NOT the clicked on suggest term.
Screen Shot 2020-07-09 at 2 12 08 PM

In this image's example Mirador sent off a request for pos but I clicked on possible.

I noticed there's an RC out as well so I gave that a try: ( "mirador": "3.0.0-rc.3" ):
When I tried the same interaction as stated above against 3.0.0-rc.3 I received the following error:

TypeError: Cannot read property ‘annotations’ of undefined
at Function.mapToProps (http://localhost:18080/assets/images/mirador.min.js:2:636409)
at r (http://localhost:18080/assets/images/mirador.min.js:2:19759)
at Function.r.mapToProps (http://localhost:18080/assets/images/mirador.min.js:2:19895)
at r (http://localhost:18080/assets/images/mirador.min.js:2:19759)
at http://localhost:18080/assets/images/mirador.min.js:2:21124
at http://localhost:18080/assets/images/mirador.min.js:2:18547
at Object.useMemo (http://localhost:18080/assets/images/mirador.min.js:2:1344097)
at t.useMemo (http://localhost:18080/assets/images/mirador.min.js:2:1281106)
at S (http://localhost:18080/assets/images/mirador.min.js:2:18491)
at Ki (http://localhost:18080/assets/images/mirador.min.js:2:1339245)

The associated "CompanionWindow":
miradorErrorCompanionWindow.txt

And for reference here's the output for my search and autocomplete service:
Search:
Request: http://localhost:8080/server/iiif/search/286a853d-3cf9-4a94-8044-d41dbbebe508?q=possible
Output:
IIIFSearchOutput.txt

Suggest:
Request: http://localhost:8080/server/iiif/search/suggest/286a853d-3cf9-4a94-8044-d41dbbebe508?q=pos
Output:
IIIFSuggestOutput.txt

Thanks for reading.

@cbeer
Copy link
Collaborator

cbeer commented Jul 10, 2020

We made some major changes to the autocomplete widget after beta.10, and I'm not able to replicate this with our latest release candidate. Could you try with one of our newer releases (like rc.3) and verify this has since been fixed? Feel free to reopen this issue if it's still a problem.

@cbeer cbeer closed this as completed Jul 10, 2020
@AndrewZachWood
Copy link
Author

@cbeer I also tested with rc3 like I stated in the initial post... I even provided the error I was given testing the issue and provided the related output.

@cbeer
Copy link
Collaborator

cbeer commented Jul 10, 2020

Ok. Since your endpoints are private, can you also give it a try with:

http://mirador-dev.netlify.app

and

https://deploy-preview-3211--mirador-dev.netlify.app

and let us know how it goes?

@cbeer
Copy link
Collaborator

cbeer commented Jul 10, 2020

Excellent. #3211 had my best guess at the problem. I'll mark that ready to go and we'll get it into the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants