-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No dialogs with Download and Share plugins in Angular 9 #3281
No dialogs with Download and Share plugins in Angular 9 #3281
Comments
dependencies in package.json are:
Maybe there are other react dependencies that must be included? |
OK. I figured it out that it happens only when miradorAnnotationPlugin and I import Mirador like this: Maybe I do something wrong with imports? Or it's a bug witj annotations plugin? |
I have an example of using mirador-image-tools, mirador-dl-plugin, and mirador-annotations together here: https://github.com/ProjectMirador/mirador-integration/pull/2/files that works. Does yours look similar? |
That is my code.
What are those three dots in front of plugin variable name? My code works only if I disable annotations plugin. Then it works OK. But if I add annotations then this bug appears. |
The three dots are the JavaScript spread syntax. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax Try changing this: - import {default as LocalStorageAdapter} from 'node_modules/mirador-annotations/lib/LocalStorageAdapter.js';
+ import LocalStorageAdapter from 'mirador-annotations/es/LocalStorageAdapter'; |
No, no luck. As I said before, if I import miradorAnnotationPlugin only and add annotation: to Mirador config, then annotations are working fine. If I import miradorDownloadPlugin/MiradorDownloadDialog or/and miradorSharePlugin/miradorShareDialogPlugin without adding miradorAnnotationPlugin to Mirador, then download and share plugins are working. I can see "Share" and "Download" buttons on the window menu. And if I press these menu options, download or share dialogs appear. I can create Angular project and push it to my github and share it with you, so you could see it by your self. |
Here is the link: Mirador Angular bug |
Thanks for providing the example that is very helpful. I'm seeing perhaps an issue with the interaction between |
Your welcome. I hope that it will be useful. |
@daynewss please try updating to mirador-annotations@v0.3.1 |
Yes, it's working. |
Mirador 3
Hello
I am working with Angular 9 project.
I have working Mirador, with Annotation, ImageTools, Share and Download plugins. Problem is that I can see Share and Download plugins in menu, but when I select these item nothing happens. Nothing at all. No exceptions in console.
I see
target: 'Window'
in MiradorDownloadDialog.js and MiradorShareDialog.js. Maybe it must be something else in Angular?My Mirador config in TS file:
The text was updated successfully, but these errors were encountered: