New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use exit 0 instead of || true to make sure postinstall works on Windows #1030

Merged

JoshuaSchmidt-OpenSea merged 1 commit into main from postinsallBugFix

Jun 7, 2023

Contributor

JoshuaSchmidt-OpenSea commented Jun 7, 2023

On windows, there's no true. Looking at other popular packages, I believe || exit 0 is a more reliable way to handle this .


          Use exit 0 instead of || true to make sure postinstall works on Windows

JoshuaSchmidt-OpenSea requested a review from a team

June 7, 2023 21:51

ryanio approved these changes

View reviewed changes

JoshuaSchmidt-OpenSea merged commit 923218e into main

8 checks passed

JoshuaSchmidt-OpenSea deleted the postinsallBugFix branch

June 7, 2023 21:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment