This repository has been archived by the owner on Sep 1, 2023. It is now read-only.
Better support filtering approvals #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
operatorfilterer
commented
Nov 14, 2022
operatorfilterer
commented
- add new modifier for filtering approvals
- add approvals to examples
- only check msg.sender in existing modifier
|
This is a much better experience for end users, so that they don't end up wasting gas on an approval for a token they cannot transfer |
emo-eth
force-pushed
the
filter-approvals
branch
from
e902219
to
354f613
Compare
emo-eth
force-pushed
the
filter-approvals
branch
from
354f613
to
22dea97
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.