Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix upgradeable #125

Merged
merged 3 commits into from Apr 19, 2024
Merged

fix upgradeable #125

merged 3 commits into from Apr 19, 2024

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented Apr 19, 2024

closes #124

@coveralls
Copy link

coveralls commented Apr 19, 2024 •
edited

Pull Request Test Coverage Report for Build 8757034938

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 59.379%
Files with Coverage Reduction New Missed Lines %
src/test/MockTransferValidator.sol 1 30.77%
Totals Coverage Status
Change from base Build 8624225376: 0.06%
Covered Lines: 548
Relevant Lines: 764
💛 - Coveralls

@ryanio ryanio merged commit 347d58e into main Apr 19, 2024
8 checks passed
@ryanio ryanio deleted the ryan/fix-upgradeable branch April 19, 2024 17:01
opensea712 added a commit to megavoltcorp/seadrop that referenced this pull request Apr 22, 2024
@opensea712
Merge pull request #1 from ProjectOpenSea/main
991cc7f 
fix upgradeable (ProjectOpenSea#125)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BCLeFevre BCLeFevre BCLeFevre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgradable contract issue
3 participants
@ryanio @coveralls @BCLeFevre