Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test case for empty domain tag #232

Merged
merged 3 commits into from May 9, 2023
Merged

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented May 9, 2023

Adds test case for #222

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b51f27e) 93.13% compared to head (09959ac) 93.13%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #232   +/-   ##
=======================================
  Coverage   93.13%   93.13%           
=======================================
  Files          16       16           
  Lines        3786     3788    +2     
  Branches      334      334           
=======================================
+ Hits         3526     3528    +2     
  Misses        250      250           
  Partials       10       10           
Impacted Files Coverage Δ
src/utils/usecase.ts 89.51% <100.00%> (+0.17%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryanio ryanio merged commit 59bcd77 into main May 9, 2023
3 checks passed
@ryanio ryanio deleted the ryan/empty-domain-tag-test-case branch May 9, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants