-
Notifications
You must be signed in to change notification settings - Fork 587
/
FulfillmentOverflowWithMissingItems.spec.ts
150 lines (130 loc) · 4.17 KB
/
FulfillmentOverflowWithMissingItems.spec.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
import { expect } from "chai";
import { constants } from "ethers";
import { network } from "hardhat";
import { toFulfillment } from "../utils/encoding";
import { seaportFixture } from "../utils/fixtures";
import { getWalletWithEther } from "../utils/impersonate";
import type {
ConsiderationInterface,
TestERC20,
TestERC721,
} from "../../typechain-types";
import type { SeaportFixtures } from "../utils/fixtures";
import type { AdvancedOrder, OfferItem } from "../utils/types";
import type { Wallet } from "ethers";
const IS_FIXED = true;
describe("Fulfillment applier allows overflow when a missing item is provided", async () => {
let alice: Wallet;
let bob: Wallet;
let order: AdvancedOrder;
let maliciousOrder: AdvancedOrder;
let marketplaceContract: ConsiderationInterface;
let testERC20: TestERC20;
let testERC721: TestERC721;
let createOrder: SeaportFixtures["createOrder"];
let getTestItem20: SeaportFixtures["getTestItem20"];
let getTestItem721: SeaportFixtures["getTestItem721"];
let mintAndApprove721: SeaportFixtures["mintAndApprove721"];
let mintAndApproveERC20: SeaportFixtures["mintAndApproveERC20"];
after(async () => {
await network.provider.request({
method: "hardhat_reset",
});
});
before(async function () {
if (process.env.REFERENCE) {
this.skip();
}
alice = await getWalletWithEther();
bob = await getWalletWithEther();
({
createOrder,
getTestItem20,
getTestItem721,
marketplaceContract,
mintAndApprove721,
mintAndApproveERC20,
testERC20,
testERC721,
} = await seaportFixture(await getWalletWithEther()));
// ERC721 with ID = 1
await mintAndApprove721(alice, marketplaceContract.address, 1);
// ERC20 with amount = 1100
await mintAndApproveERC20(bob, marketplaceContract.address, 1);
});
it("Alice offers to sell an NFT for 1000 DAI", async () => {
const offer = [getTestItem721(1, 1, 1)];
const consideration = [getTestItem20(1000, 1000, alice.address)];
const results = await createOrder(
alice,
constants.AddressZero, // zone
offer,
consideration,
0, // FULL_OPEN
[], // criteria
null, // timeFlag
alice, // signer
constants.HashZero, // zoneHash
constants.HashZero, // conduitKey
true // extraCheap
);
order = results.order;
});
it("Bob constructs a malicious order with one empty consideration and one which will overflow Alice's", async () => {
const offer: OfferItem[] = [getTestItem20(1, 1)];
const consideration = [
getTestItem721(1, 1, 1, bob.address),
getTestItem20(0, 0, alice.address),
getTestItem20(
constants.MaxUint256.sub(998),
constants.MaxUint256.sub(998),
alice.address
),
];
const results = await createOrder(
bob,
constants.AddressZero,
offer,
consideration,
1
);
maliciousOrder = results.order;
});
describe("Bob attempts to match Alice's order with his malicious order", () => {
const fulfillments = [
toFulfillment([[0, 0]], [[1, 0]]),
toFulfillment(
[[1, 0]],
[
[0, 0],
[1, 1],
[1, 2],
]
),
];
if (!IS_FIXED) {
it("Bob is able to match Alice's order with his malicious one", async () => {
await marketplaceContract
.connect(bob)
.matchAdvancedOrders([order, maliciousOrder], [], fulfillments);
});
it("Bob receives Alice's NFT, having paid 1 DAI", async () => {
expect(await testERC721.ownerOf(1)).to.equal(bob.address);
expect(await testERC20.balanceOf(bob.address)).to.equal(0);
});
it("Alice receives 1 DAI", async () => {
expect(await testERC20.balanceOf(alice.address)).to.equal(1);
});
} else {
it("The transaction reverts", async () => {
await expect(
marketplaceContract
.connect(bob)
.matchAdvancedOrders([order, maliciousOrder], [], fulfillments)
).to.be.revertedWith(
"panic code 0x11 (Arithmetic operation underflowed or overflowed outside of an unchecked block)"
);
});
}
});
});