Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SignedZone #895

Closed
wants to merge 17 commits into from
Closed

Add SignedZone #895

wants to merge 17 commits into from

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented Jan 20, 2023

Adds SignedZone, compliant with with SIP-7

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2023

Codecov Report

Base: 64.82% // Head: 99.05% // Increases project coverage by +34.22% 🎉

Coverage data is based on head (8d2df5f) compared to base (976956d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##              1.2     #895       +/-   ##
===========================================
+ Coverage   64.82%   99.05%   +34.22%     
===========================================
  Files         107       47       -60     
  Lines        4421     2642     -1779     
  Branches      559      391      -168     
===========================================
- Hits         2866     2617      -249     
+ Misses       1532       25     -1507     
+ Partials       23        0       -23     
Flag Coverage Δ
foundry 74.26% <ø> (+26.61%) ⬆️
production 100.00% <ø> (ø)
reference 100.00% <ø> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/test/TestERC1155Revert.sol
contracts/test/InvalidERC721Recipient.sol
test/foundry/utils/ArithmeticUtil.sol
test/foundry/utils/BaseConsiderationTest.sol
test/foundry/utils/ERC1155Recipient.sol
contracts/test/ConduitMock.sol
contracts/test/ConduitMockRevertBytes.sol
contracts/test/TestERC20.sol
contracts/test/TestContractOffererNativeToken.sol
contracts/test/TestInvalidContractOfferer.sol
... and 54 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryanio ryanio marked this pull request as ready for review January 20, 2023 20:46
@0age 0age deleted the branch 1.2 February 1, 2023 23:16
@0age 0age closed this Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants