Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try removing jupyter_server version pin #123

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

brian-rose
Copy link
Member

Do we still need this?

@github-actions
Copy link

github-actions bot commented Jun 20, 2023

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 36a593a
✅ Deployment Preview URL: https://ProjectPythia.github.io/cookbook-template/_preview/123

@brian-rose
Copy link
Member Author

The pin was introduced in #101 to resolve #100 due to some upstream changes.

Is this still needed?

@brian-rose
Copy link
Member Author

It looks like the answer is no, we do not still need this pin.

@brian-rose brian-rose marked this pull request as ready for review June 20, 2023 02:12
@brian-rose
Copy link
Member Author

I'm going to merge this now (pre-hackathon) because it looks like removing this pin helps resolve some dependency issues on the binder.

@brian-rose brian-rose merged commit 3c521ae into ProjectPythia:main Jun 20, 2023
3 checks passed
@brian-rose brian-rose deleted the no-pin branch June 20, 2023 04:24
github-actions bot pushed a commit that referenced this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant