Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention that SST is called tos in the model #390

Merged
merged 1 commit into from
May 3, 2023

Conversation

ejlevine
Copy link
Contributor

@ejlevine ejlevine commented May 2, 2023

I'm submitting this, my 1st ProjectPythia PR, per the instructions in the Pythia Foundations Book, in the section "Contribute to Project Pythia via Github".

https://foundations.projectpythia.org/foundations/github/contribute-to-pythia.html

BTW, this sections says "Let’s add the content tag and open this one as a draft for now", but I don't see a way to add tags in github.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ejlevine ejlevine marked this pull request as ready for review May 2, 2023 21:18
@ejlevine ejlevine requested a review from a team as a code owner May 2, 2023 21:18
@ejlevine ejlevine requested review from clyne and jukent and removed request for a team May 2, 2023 21:18
@jukent
Copy link
Contributor

jukent commented May 2, 2023

Thanks for your contribution @ejlevine ! I will wait for the checks to pass before approving.

Copy link
Contributor

@clyne clyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@clyne clyne merged commit 109016a into ProjectPythia:main May 3, 2023
2 checks passed
@ejlevine ejlevine deleted the clarify-sst-tos branch May 3, 2023 14:56
jukent added a commit that referenced this pull request May 8, 2023
* Mention that SST is called tos in the model (#390)

* fix broken link (#393)

---------

Co-authored-by: Eric Levine <ejlevine@pm.me>
jukent added a commit that referenced this pull request May 22, 2023
* Create CITATION.cff

* Update CITATION.cff

* Update CITATION.cff

* add all contributors and change title

* cff-version wrong

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update CITATION.cff

Co-authored-by: Brian Rose <brose@albany.edu>

* Update CITATION.cff

Co-authored-by: Brian Rose <brose@albany.edu>

* Update CITATION.cff

Co-authored-by: Robert Ford <50349951+r-ford@users.noreply.github.com>

* Update CITATION.cff

Co-authored-by: Max Grover <mgroverwx@gmail.com>

* Update CITATION.cff

Co-authored-by: Anderson Banihirwe <13301940+andersy005@users.noreply.github.com>

* Update CITATION.cff with ORCIDs

* Updates from main (#394)

* Mention that SST is called tos in the model (#390)

* fix broken link (#393)

---------

Co-authored-by: Eric Levine <ejlevine@pm.me>

* more orcids

* kpaul orcid

* one more orcid

* added final orcid

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Brian Rose <brose@albany.edu>
Co-authored-by: Robert Ford <50349951+r-ford@users.noreply.github.com>
Co-authored-by: Max Grover <mgroverwx@gmail.com>
Co-authored-by: Anderson Banihirwe <13301940+andersy005@users.noreply.github.com>
Co-authored-by: Eric Levine <ejlevine@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants