Remove old version pins from environment #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
brian-rose
requested review from
jukent and
r-ford
and removed request for
a team
|
Looks good to me. Opening this up for review and merge. |
jukent
approved these changes
Aug 24, 2023
jukent
pushed a commit
to jukent/pythia-foundations
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing if we can now remove two likely-obsolete version pins from the environment file.
The scipy pin was introduced recently in #414 waiting until the next Cartopy release. That has happened so we shouldn't need the pin anymore.
The other pin is much older, dating back to the first introduction of the Cartopy notebook #24. I'm not sure the original reason this was needed, but I suspect it's obsolete now.
Testing to see if everything works!