Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Array Slicing Syntax from 'array[start:stop[:step]]' to 'array[start:stop:step]' #465

Merged
merged 3 commits into from
May 20, 2024
Merged

Clarify Array Slicing Syntax from 'array[start:stop[:step]]' to 'array[start:stop:step]' #465

merged 3 commits into from
May 20, 2024

Commits on Apr 26, 2024

  1. Clarified Array Slicing Syntax

    @kazakhpunk
    kazakhpunk committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    24e9474 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Update numpy-basics.ipynb 

    Thank you for the feedback. I appreciate the concern about the notation implying that the second colon and the step parameter are mandatory. 

I propose we adopt 'array[start:stop:step]' as the primary notation in examples but include a clear note in the text explaining that the step parameter is optional: "The step parameter is optional and can be omitted, in which case the slice uses a default step of 1."
    @kazakhpunk
    kazakhpunk committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    d16dafa View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Resolved issue with wrong use of parenthesis

    @kazakhpunk
    kazakhpunk committed May 8, 2024
    Configuration menu
    Copy the full SHA
    b9d995e View commit details
    Browse the repository at this point in the history