Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function for bounding number of Trotter steps required #121

Merged
merged 9 commits into from
Jul 21, 2017
Merged

Function for bounding number of Trotter steps required #121

merged 9 commits into from
Jul 21, 2017

Conversation

idk3
Copy link
Collaborator

@idk3 idk3 commented Jul 19, 2017

No description provided.

@idk3 idk3 requested a review from babbush July 19, 2017 01:08
@idk3
Copy link
Collaborator Author

idk3 commented Jul 19, 2017

@babbush correct me if I'm wrong, but I think this should be the right formula for multiple Trotter steps. I mostly see the single-step formula and was confused about whether there should be a square root.

Copy link
Contributor

@babbush babbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, what happened to the square root?

Copy link
Contributor

@babbush babbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the have the sqrt in the bound, as we discussed.

@idk3
Copy link
Collaborator Author

idk3 commented Jul 20, 2017

Following the discussion with Nathan, we should be calculating the maximum time we can safely evolve, rather than the number of Trotter steps we need. I'll update this soon.

@babbush babbush merged commit ffb98da into ProjectQ-Framework:develop Jul 21, 2017
@idk3 idk3 deleted the estimate_number_of_trotter_steps branch July 25, 2017 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants