Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more type annotations to FermionOperator docstrings #36

Merged
merged 4 commits into from
May 22, 2017
Merged

Add more type annotations to FermionOperator docstrings #36

merged 4 commits into from
May 22, 2017

Conversation

Strilanc
Copy link
Collaborator

No description provided.

babbush
babbush suggested changes May 20, 2017
View reviewed changes
Copy link
Contributor

@babbush babbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the deal with changing "subtrahend" and "addend" to "offset". Though unusual, these are the correct words. I'd recommend putting those back to subtrahend and addend.

@Strilanc
Copy link
Collaborator Author

@babbush Done.

@damiansteiger damiansteiger self-requested a review May 21, 2017 04:10
@babbush
Copy link
Contributor

babbush commented May 22, 2017

Thanks for cleaning this stuff up!

@babbush babbush merged commit e6de198 into ProjectQ-Framework:develop May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babbush babbush babbush approved these changes

@damiansteiger damiansteiger Awaiting requested review from damiansteiger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Strilanc @babbush