New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RevKit interface #217
RevKit interface #217
Conversation
…ork/ProjectQ into feature/revkit-interface
RevKit interface: PermutationOracle
Awesome, thanks! It looks great except for a few pep8 issues (which I could fix if you like) and I was wondering if there is a chance we could change the writing to a file and then |
Thanks for the feedback. And both good ideas. I can fix the pep8 issues and will also modify the interface to avoid writing to files. I'll push the changes within a few days. |
qubit2 = Qubit(main_engine, 2) | ||
qubit3 = Qubit(main_engine, 3) | ||
|
||
ControlFunctionOracle(maj) | ([qubit0, qubit1, qubit2], qubit3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this test?
Would be great to incorporate this PR before the next release. I fixed the pep8 issues. A few things:
Rerunning was so far successful in fixing this. But maybe we should check if we find a more stable solution ;)
|
The reimplementation somehow diverged the branches too much such that it was cleaner to open a new PR #241 and close this one. |
I propose to merge the RevKit feature into develop. The tests are running with 100% coverage, the code is documented, and there are two examples. I am happy to add more functionality in the future. I also thought of having some simple Python-based fallback algorithms for synthesis that can be called if RevKit is not installed but do not guarantee the same quality of results.