Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
setup
parameter from MainEngine (has not yet been merged to Master).This parameter has been introduced to make the compiler engine specifications more explicit instead of just
import projectq.setups.ibm
. Now it is even more explicit: One needs to set theengine_list
parameter:Advantages is that one can give the function
get_engine_list
parameters, e.g., we can build a compiler engine setup for a linear chain and give it as a parameter the length of the chain:Downsides:
setup
parameter was nice, maybe in future we can use that parameter to set theengine_list
and change the defaultbackend
in case the user does not provide one (Previously it only set theengine_list
)Other options to this PR:
setup_parameters
which should take adict
in order that we can check correct parameter names as each setup might have different ones.I.e.