Change BasicGate __eq__ to test for matrix attribute #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 7, 2018 13:53
… using basic gate this way
thomashaener
approved these changes
Aug 7, 2018
| gate = BasicGate() | ||
| gate.matrix = numpy.matrix([[1,0],[0, -1]]) | ||
| """ | ||
| if hasattr(self, 'matrix'): |
There was a problem hiding this comment.
To make these case distinctions more concise, one could use sum([hasattr(g, 'matrix') for g in [self, other]]) instead, but the current implementation is simpler to understand so either is fine with me.
There was a problem hiding this comment.
Nice trick, I will use it once I have more cases to compare.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order that user can do:
And have a correct
__eq__