Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl generalize #400

Merged
merged 35 commits into from
Jun 16, 2021
Merged

Ctrl generalize #400

merged 35 commits into from
Jun 16, 2021

Conversation

XYShe
Copy link
Contributor

@XYShe XYShe commented Jun 14, 2021

Add support for off-control

XYShe and others added 24 commits June 14, 2021 21:17
@XYShe
Init
5a14f35
@XYShe
Apply control through compute engine. Added Enum class
64ecab4
@XYShe
Apply control through compute engine. Added Enum class
8e39bc9
@XYShe
Apply control through compute engine, added enum class
943b2ae
@XYShe
Fix small bug due to wrong default value, clean up output
c90da68
@XYShe
abolished decomp
8c64487
@XYShe
Revert "abolished decomp"
7ff9963 
This reverts commit 36743a1.
@XYShe
Apply Control through decomposition. Added Test Files
4061b4c
@Takishima @XYShe
Fix a few issues with new control state
51d0feb 
- Address inconsistency with qubit state ordering when using integers
  as input control state
- Add canonical_ctrl_state function to centralise functionality
- Fix some file encoding
- Fix tests
@Takishima @XYShe
Update examples/control_tester.py
e5b1476
@Takishima @XYShe
Add some missing license headers and fix some tests
c4ccc5a
@Takishima @XYShe
Add missing docstring
c5940cc
@Takishima @XYShe
Cleanup some code in AQT and IBM backends
7392791
@Takishima @XYShe
Some code cleanup in _simulator.py
d2a918c
@XYShe
Change autoreplacer priority for control. Added Additional test for a…
fe28671 
…utoreplacer. Added check for canonical ctrl state func.
@Takishima @XYShe
Update projectq/setups/default.py
3770a53
@Takishima @XYShe
Update projectq/setups/decompositions/cnu2toffoliandcu.py
0843e92
@Takishima @XYShe
Update projectq/setups/decompositions/cnu2toffoliandcu.py
ddb35de
@Takishima @XYShe
Cleanup code in _replacer.py
6b163a9
@Takishima @XYShe
Tweak some of the unit tests + add comments
02ab04a
@Takishima @XYShe
Add more tests for canonical_ctrl_state and has_negative_control
d950a6c
@Takishima @XYShe
Short pass of reformatting using black
500b1ca
@XYShe
Bug fixing for rebasing
a2b3cb9
@XYShe
Reformat files. Improve control_tester examples. Update change log
d15e3ec
Takishima
Takishima approved these changes Jun 15, 2021
View reviewed changes
Copy link
Collaborator

@Takishima Takishima left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; we anyway have been discussing this outside of GitHub for a while now. There are just a couple of CI errors that need investigating before merging but do not seem to be related to this PR anyway.

@coveralls
Copy link

coveralls commented Jun 15, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 942731416

  • 126 of 126 (100.0%) changed or added relevant lines in 12 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 99.125%
Totals Coverage Status
Change from base Build 936319582: 0.009%
Covered Lines: 6913
Relevant Lines: 6974
💛 - Coveralls

@Takishima
Add support for AWSBraketBackend
5aae1b8
@Takishima
Fix small typo
3014d2e
@Takishima
Use backported mock instead of unittest.mock
1a6182f
@Takishima
Sort requirements_tests.txt
8128b1d
@Takishima
Fix a bunch of errors that happens at program exit
9a983bf 
 Monkeypatching or patching of external may unload the patch before
 the MainEngine calls the last flush operations which would then call
 the original API although unwanted.
@Takishima Takishima merged commit aa3afaf into ProjectQ-Framework:develop Jun 16, 2021
@Takishima Takishima deleted the ctrl_generalize branch June 16, 2021 12:29
@Takishima Takishima mentioned this pull request Jun 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Takishima Takishima Takishima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@XYShe @coveralls @Takishima