Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webcast banner & breadcrumbs #146

Closed
alexgleason opened this issue Dec 17, 2019 · 4 comments
Closed

Fix webcast banner & breadcrumbs #146

alexgleason opened this issue Dec 17, 2019 · 4 comments
Assignees
Milestone

Comments

@alexgleason
Copy link
Contributor

This is something we didn't really account for, but it's clearly wrong. Look at the banner:

Screenshot from 2019-12-16 20-56-22

This doesn't match the mockup, which looks like this:

webcast-page

The breadcrumbs are problematic because they extend too far. The banner returns the page title, which IMO is the correct thing to do, but it's redundant with the body content. The mockup uses the parent's page title, the only place on the site which does that. Needs design consideration.

@alexgleason
Copy link
Contributor Author

I'm wondering if we should have this design:

Screenshot from 2019-12-17 16-17-01

Related: #148

@marykatefain
Copy link
Contributor

This is a cool idea - but not a small thing.

@marykatefain
Copy link
Contributor

A hack but easy solution to this is to set talk_title as a separate field, and then just make the title field what we want it to say.

@marykatefain
Copy link
Contributor

Internal Page Title = same as schedule page

breadcrumbs: . / webcast / Name of Speaker

alexgleason added a commit that referenced this issue Dec 18, 2019
Custom breadcrumbs for webcast pages, fixes #146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants