Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♿ api:data_getを実行時該当ストレージを一旦削除するように #1496

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

♿ api:data_getを実行時該当ストレージを一旦削除するように #1496

wants to merge 3 commits into from

Conversation

haiiro2gou
Copy link
Member

@haiiro2gou haiiro2gou commented Apr 8, 2024 •
edited
Loading

nullになるやつだけ消そうね

@haiiro2gou haiiro2gou requested a review from ChenCMD as a code owner April 8, 2024 10:02
@haiiro2gou haiiro2gou marked this pull request as draft April 10, 2024 16:48
@haiiro2gou haiiro2gou marked this pull request as ready for review May 18, 2024 05:50
ChenCMD
ChenCMD requested changes May 18, 2024
View reviewed changes
Copy link
Member

@ChenCMD ChenCMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nullable な場合はそこを消すだけじゃなくて selected_item(_fetch) みたいに、DataCache 側にも工夫をいれる必要があるはずなので一緒にやる必要がありそう

ChenCMD
ChenCMD requested changes May 18, 2024
View reviewed changes
Copy link
Member

@ChenCMD ChenCMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nullable な場合はそこを消すだけじゃなくて selected_item(_fetch) みたいに、DataCache 側にも工夫をいれる必要があるはずなので一緒にやる必要がありそう

@haiiro2gou
Copy link
Member Author

playerがnullを取りかねないような値は切り替えたけど
他entityにも対応させるつもりなら全部fetchしてしまった方がいいのでは…？

@haiiro2gou haiiro2gou requested a review from ChenCMD May 19, 2024 14:36
@ChenCMD
Copy link
Member

ChenCMD commented May 24, 2024

data_get はそもそもパフォーマンスの観点から利用されてるに過ぎないもので、これを非 player に使うかの判断は非常に難しいことから一律に player 限定とするのが楽に思えるね

@haiiro2gou
Copy link
Member Author

明らかにプレイヤーが値を持たないmcfはこのまま置いたままで大丈夫？

@ChenCMD
Copy link
Member

ChenCMD commented May 24, 2024

実運用上は持ち得ないかもしれないけど、この NBT の一覧は確かソースコード上のものから来てるから、ソースコード上は持ち得るはずなので、このままでいいかな

@haiiro2gou
Copy link
Member Author

エンティティ共通nbtか、了解
じゃあこの状態でレビューお願いします

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenCMD ChenCMD Awaiting requested review from ChenCMD ChenCMD is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@haiiro2gou @ChenCMD