Skip to content

Commit

Permalink
Add Solidified v2 audit report
Browse files Browse the repository at this point in the history
  • Loading branch information
protinam committed Mar 7, 2018
1 parent 9e6b1e4 commit a62a94b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions audits/v2/AUDIT_RESPONSE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
In response to the issues found in the audit report:

1. Indeed, with the current EVM design, it is impossible to guarantee that a contract will never receive Ether. The balance assertion has been removed.

2. This is intentional. When paying fees in the protocol token, Exchange users have the option to pay no fees. Relayers, which host off-chain orderbooks, can require particular fees for submission to their orderbooks.

3. Relayers can choose to whitelist or blacklist tokens to prevent user confusion, so implementing token restrictions at the protocol layer is unnecessary.
Binary file added audits/v2/solidified_v2_audit_report.pdf
Binary file not shown.

0 comments on commit a62a94b

Please sign in to comment.