Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a batching uploader #5

Merged
merged 3 commits into from
Apr 26, 2023
Merged

add a batching uploader #5

merged 3 commits into from
Apr 26, 2023

Conversation

dan-pulley
Copy link
Collaborator

this adds a batch uploader that cuts about 40% off of the upload time

Copy link
Contributor

@bessiambre bessiambre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, closures and continuation passing, nice.

@dan-pulley dan-pulley merged commit d993017 into main Apr 26, 2023
1 check passed
@dan-pulley dan-pulley deleted the feature/no_round_trip_uploader branch April 26, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants