Pull upstream to fix pow with decimals #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add initial implementation of natural logarithm * Add constApproxmation struct to represent mathematical constants with their approximations
…#340) * Update Github Actions libraries to the latest working version * Update badge to show status from master branch only
Co-authored-by: Chris Belsole <chris.belsole@homelight.com>
Given the interface definition
type Ordered[T any] interface {
Compare(T) int
}
And the type constraint T Ordered[T], make decimal.Decimal satisfy this
constraint, so that generic code written against T Ordered[T] can work
with decimal values as smoothly as it works with time.Time values today.
Fixes: shopspring#345
* Adjust Ln method to prevent infinity iteration loops * Add test case for infinity loop
* Adjust Pow implementation * Add PowWithPrecision method * Add PowInt32 method * Add PowBigInt method
* Drop support for Go versions older than 1.10 * Remove 1.18 from test suite
BogdanIrimie
changed the title
BogdanIrimie
requested review from
viovanov,
marcosvlehmkuhl,
bessiambre and
ankojh
oanatmaria
reviewed
May 19, 2024
| @@ -1,3 +1,3 @@ | |||
| module github.com/ProlificLabs/decimal | |||
|
|
|||
| go 1.13 | |||
| go 1.10 | |||
There was a problem hiding this comment.
Is there a reason we downgrade the go version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on upstream because it fixes pow with decimal numbers shopspring#55 (comment)