code optimized. Fixes#166

Promact · Feb 24, 2017 · d51e345 · d51e345
1 parent c5c4834
commit d51e345
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/Slack.Automation/Promact.Core.Repository/ScrumRepository/ScrumBotRepository.cs b/Slack.Automation/Promact.Core.Repository/ScrumRepository/ScrumBotRepository.cs
@@ -355,12 +355,10 @@ private async Task UpdateTemporaryScrumDetailsAsync(string slackUserId, int scru
         /// <returns>true if active else false</returns>
         private async Task<bool> CheckUserAsync(string slackUserId, List<User> users, string teamLeaderId)
         {
-            User user = users.FirstOrDefault(x => x.SlackUserId == slackUserId);
+            User user = users.FirstOrDefault(x => x.SlackUserId == slackUserId);   
             if (user == null)
             {
-                ApplicationUser teamLeader = await _applicationUser.FirstOrDefaultAsync(x => x.Id == teamLeaderId && x.SlackUserId == slackUserId);
-                if (teamLeader != null)
-                    return true;
+                return (await _applicationUser.FirstOrDefaultAsync(x => x.Id == teamLeaderId && x.SlackUserId == slackUserId) != null);
             }
             if (user != null && user.IsActive)
                 return true;