-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProcessCollector has "untyped" metrics #78
Comments
Wow! Thank you for reporting and contributing to fix this issue. Is it happens on "empty" Prometheus, or because your Prometheus instance already has process_processid metric but gauge instead of untyped? |
Hi! This happens on an "empty" Prometheus (as viewed from my app), but notice that Prometheus also scrapes the other services in the Prometheus stack where these two metrics are gauge instead of untyped. Specifically, the problem occurs using https://github.com/evnsio/prom-stack.
…On Wed, Sep 25, 2019 at 10:29 PM Oleksandr Poliakov < ***@***.***> wrote:
Wow! Thank you for reporting and contributing to fix this issue. Is it
happens on "empty" Prometheus, or because your Prometheus instance already
has process_processid metric but gauge instead of untyped?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#78>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABT3SE4M4C2LDDBWGUZP4FLQLPC37ANCNFSM4I2I775A>
.
--
*Øystein Haug Olsen Ph.D.*
Director of Engineering
+47 902 76 979 | oystein.olsen@cognite.com
www.cognite.com | LIBERATE YOUR DATA™
|
@oholsen Thank you for the information. We definitely have to integrate your changes. Honestly it was me who change that metrics type from gauge to untyped, as it looks semantically better. But now I can see it was not so good idea :) |
@oholsen I've merged the PR. Could you please check the latest package on MyGet to ensure that issue is being fixed? Thanks |
We have verified that the latest package on MyGet works. Will it also
appear on nuget soon?
…On Fri, Sep 27, 2019 at 6:22 PM Oleksandr Poliakov ***@***.***> wrote:
@oholsen <https://github.com/oholsen> I've merged the PR. Could you
please check the latest package on MyGet to ensure that issue is being
fixed?
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#78>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABT3SEYZ6VTMHSFSZEQGONTQLYXMJANCNFSM4I2I775A>
.
--
*Øystein Haug Olsen Ph.D.*
Director of Engineering
+47 902 76 979 | oystein.olsen@cognite.com
www.cognite.com | LIBERATE YOUR DATA™
|
@oholsen Thank you for verifying the fix. We will publish the nuget package soon (most likely tonight). Thank you again for contributing. |
Pushing metrics to Push Gateway makes Prometheus think it is down. The /metrics end-point on the Push Gateway responds with a 500:
There are two metrics at fault:
process_processid
andprocess_start_time_seconds
.In contrast, start time is a Gauge here:
https://github.com/prometheus-net/prometheus-net/blob/master/Prometheus.NetStandard/DotNetStats.cs
The text was updated successfully, but these errors were encountered: