Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProcessCollector has "untyped" metrics #78

Closed
oholsen opened this issue Sep 25, 2019 · 6 comments · Fixed by #79
Closed

ProcessCollector has "untyped" metrics #78

oholsen opened this issue Sep 25, 2019 · 6 comments · Fixed by #79
Labels

Comments

@oholsen
Copy link

oholsen commented Sep 25, 2019

Pushing metrics to Push Gateway makes Prometheus think it is down. The /metrics end-point on the Push Gateway responds with a 500:

An error has occurred:
expected gauge in metric process_start_time_seconds label:<name:"instance" value:"" > label:<name:"job" value:"pi-extractor" > untyped:<value:1.569396433e+09 > 

There are two metrics at fault: process_processid and process_start_time_seconds.

In contrast, start time is a Gauge here:
https://github.com/prometheus-net/prometheus-net/blob/master/Prometheus.NetStandard/DotNetStats.cs

@sanych-sun
Copy link
Member

Wow! Thank you for reporting and contributing to fix this issue. Is it happens on "empty" Prometheus, or because your Prometheus instance already has process_processid metric but gauge instead of untyped?

@oholsen
Copy link
Author

oholsen commented Sep 26, 2019 via email

@sanych-sun
Copy link
Member

@oholsen Thank you for the information. We definitely have to integrate your changes. Honestly it was me who change that metrics type from gauge to untyped, as it looks semantically better. But now I can see it was not so good idea :)

@sanych-sun
Copy link
Member

@oholsen I've merged the PR. Could you please check the latest package on MyGet to ensure that issue is being fixed?

Thanks

@oholsen
Copy link
Author

oholsen commented Sep 30, 2019 via email

@sanych-sun
Copy link
Member

@oholsen Thank you for verifying the fix. We will publish the nuget package soon (most likely tonight).

Thank you again for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants