Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working for touch screens? Tested: iOS 10, Chrome / Safari #48

Closed
benjibee opened this issue Mar 9, 2017 · 3 comments
Closed

Not working for touch screens? Tested: iOS 10, Chrome / Safari #48

benjibee opened this issue Mar 9, 2017 · 3 comments

Comments

@benjibee
Copy link

benjibee commented Mar 9, 2017

Forgive the silly question, but is this intended to also detect mobile scroll (swipe) actions?

The grammar isn't 100% clear and it's very much not working on mobile. Just wondering.

@f0rmat1k
Copy link
Member

f0rmat1k commented Mar 9, 2017

@benjibee It works only with mouse wheel. To get gesture on mobile devices you should use something like Hammer.js.

@f0rmat1k f0rmat1k closed this as completed Mar 9, 2017
@benjibee
Copy link
Author

benjibee commented Mar 9, 2017

Ok, thanks for the clarification. I find the below text to be quite ambiguous, though the list of events is not:

Generates event when user makes new movement (like a touchstart on a touchscreen)

In addition, wouldn't it be quite trivial to add touchstart and touchend support to this? It seems strange to include Hammer.js when just looking to detect scrolling / swiping up and down, IMO.

@f0rmat1k
Copy link
Member

f0rmat1k commented Mar 9, 2017

@benjibee I agree about the text. I will change it.
But adding touchstart, touchend it more complicated task, than it looks like. And already there are libraries, that give it to you. The only target of wheel-indicator: to provide you imitation of touchstart on mouses and touchpades. We usually connect this library for desktop browsers and hammer.js for touch devices.

@benjibee benjibee changed the title No longer working? Tested: iOS 10, Chrome / Safari Not working for touch screens? Tested: iOS 10, Chrome / Safari Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants