-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support passive listener #50
Comments
In the latest version of OsX Chrome (Version 73.0.3683.86 (Official Build) (64-bit)) this now leads to console errors. Is somebody looking in to this?
|
@harmvandeven I use 67.0.3396.87 (Official Build) (64-bit) So I continue with the solution above, and can't offer any suggestion. |
This PR should fix it, let me know if you have any troubles! |
thanks |
added with wheel-indicator@1.2.2 |
Please see here:
https://developers.google.com/web/tools/lighthouse/audits/passive-event-listeners
https://github.com/WICG/EventListenerOptions/blob/gh-pages/explainer.md#feature-detection
The workaround for Lighthouse report is to test for passive support
If fails, include polyfill
and change in wheel-indicator.js
In that case the Lighthouse addon for Chrome is happy.
I suspect in other use cases the solution above may not be acceptable.
The text was updated successfully, but these errors were encountered: