Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: "Invalid Partner Login" on user/password failure is misleading #263

Closed
nogweii opened this issue May 22, 2012 · 5 comments

Comments

@nogweii
Copy link

nogweii commented May 22, 2012

It seems the Android client is using a new password, getting these errors using git-HEAD:

Welcome to pianobar (2012.05.06-dev)! Press ? for a list of commands.
[?] Email: foo@bar
[?] Password: 
(i) Login... Error: Invalid partner login.

EDIT: It was actually my bad, I typo'd my password. Please improve the error message. If I mistyped my password, I'd like to know.

@kreed
Copy link

kreed commented May 22, 2012

Working fine here, and there have been no updates to the Android client according to the market page.

pianobar also gives this error when your username/password is wrong, so check that first.

@PromyLOPh
Copy link
Owner

The error message is a bit misleading I guess, although the error codes
for invalid partner login and invalid user login are the same.

@kreed
Copy link

kreed commented May 23, 2012

You could check if the error occurs from auth.partnerLogin or auth.userLogin to differentiate between them easily enough.

@nogweii
Copy link
Author

nogweii commented May 23, 2012

You're right - it was actually my bad, I did typo my password.

I'm changing this to a feature request: Can you improve the error message?

@PromyLOPh
Copy link
Owner

I'm changing this to a feature request: Can you improve the error message?
Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants