Add ability to toggle the explicit content filter #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fawaf
pushed a commit
to fawaf/pianobar
that referenced
this pull request
Aug 19, 2016
Currently exposed settings: Username, password and explicit content filter. New key for settings is ‘!’, changeable with “act_settings”. Fixes issues PromyLOPh#524 and PromyLOPh#506.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to toggle the explicit content filter using 'f' as a shortcut. This was requested in #506.
Unfortunately I was not able to use the
user.changeSettingsmethod and was getting a code 9 error back. It wasn't very clear which key it was expecting.user.setExplicitContentFilterworks fine though! 😄I hesitated from having
PIANO_REQUEST_GET_SETTINGSfill in all the data in the relevant places, or adding a new struct with unused fields, instead only filling the newPianoRequestDataGetExplicitContentFilterInfo_tstruct. Thoughts?