New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #596 - outdated documentation for setup coq-prog-xxx. #598
Conversation
I will merg e this soon if noone objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Matafou; I did a quick review and left very minor suggestions
Coq Proof General has a special experimental feature called "Holes" | ||
which makes use of the abbreviation mechanism and includes a large list | ||
of command abbreviations. @xref{Holes feature}, for details. With other | ||
provers, you may use the standard Emacs commands above to set up your | ||
own abbreviation tables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you want to remove this documentation from now on? 😉
but maybe you'd have plans to port part of the features of Holes to the same "elisp backend" as that of company-coq?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. I made a small poll on Zulip and it appear I was the only user of this feature.
I have tested yasnippet snippets for coq and it works quite well and it does not interfere with company coc completions (even if it also uses yasnippet). There are a few editing tricks that I will miss but nevermind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More precisely I plan to
- remove everything from the holes library shortly.
- document and/or propose a set of user-customized abbreviations (unless this subsumed by company-coq maybe)
- one day maybe try to reimplement the copy-paste-in-the-holes thing, even if nobody seems to be willing to try it...
So feel free @Matafou to merge this when you see fit. BTW, small remark: it happens there are 3 PR merging strategies in GitHub ( It seems actually that
However, So, maybe for merging upcoming PRs we should only use (I guess I could copy this suggestion in the wiki later on? Cc @cpitclaudel @hendriktews @Matafou @monnier FYI) |
Done FYI: https://github.com/ProofGeneral/PG/wiki/Checklist-for-testing-and-reviewing-a-PR#merging-a-pr |
Thanks @erikmd. |
3098067
to
fb7fe89
Compare
BTW @erikmd sorry for the rebase, this is the default "merge" button behaviour. |
No worries for this time ;) |
Fix #596
I did a refresh on this part of the documentation.
I propose to merge this before adapting maybe according to #590.