-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug(s) Fix: Leveraged Positions Smart Contract Example #31
Comments
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 1.2 ETH (203.51 USD @ $169.59/ETH) attached to it as part of the ProofSuite fund.
|
Issue Status: 1. Open 2. Cancelled Work has been started. These users each claimed they can complete the work by 1 month, 1 week ago. 1) dale-q has started work. I will try to write good smart contract Vou tentar faser uma verificação nesse caso ok to lay whichway to reduce ,usage use of .scr limiting ,kernel insert(ping),rcharging with caution,servicing kde. Learn more on the Gitcoin Issue Details page. |
Hey @mikedeshazer just to clarify. So it seems 1, 2, 3 are done only 4 and 5 are missing correct? I'm currently looking into this and would like to solve it today 🙂 |
@mul1sh mostly yes. Looking forward to reviewing the code! |
hey @mikedeshazer i've been going through this contract extensively for the past few days and trying to find and fix all the bugs i found. And the only bugs I seem to found relate to no. 4 only and a few syntax warnings, everything else is working as it should, apart also from the uniswap part which will be a later functionality. So my question is, were you able to find any bugs or is there anything else i've missed? |
@mikedeshazer orfeed.getExchangeRate() isn't returning values for kovan and rinkeby. |
Ahh ok, I see it now. |
@mikedeshazer actually still on no 3, I can see the settlements are being calculated and issued based on the difference of the asset price so this is also done or i'm missing something? Also shouldn't the leverage be set by the user, based on a global leverage ratio, before opening a position? This way you can easily tell whether a user made a profit or loss from their bet and reward them accordingly. |
Also by how much should the pegged token be over-collaterized should it fixed during contract creation i.e. hard code 50% where for each pegged token to mint you need atleast double the value in ether or dynamic as set by the minter |
@mul1sh yes leverage is set by user. On settlement it is calculated and distributed. |
Is there still anything left to work on? |
Issue Status: 1. Open 2. Cancelled The funding of 1.2 ETH (226.68 USD @ $188.9/ETH) attached to this issue has been cancelled by the bounty submitter
|
The Leverage Facility Token example smart contract (contracts/examples/ConsumeDataExample/ levFacilityTokenExample.sol) was created to do the following (most of which works/there is semi-working code for):
Much of the base code is there but some of the functionality is not working/math is a bit janky. First big step we need to achieve is to lay out all the things that are not working or could work better. Please leave comments/ideas if you intend to contribute (and much thanks by the way), and we can collaborate ourselves towards a capital efficient (leverage), opinionated (long and short) future!
The text was updated successfully, but these errors were encountered: