Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle Contracts for Testnets (Rinkeby & Kovan) #3

Closed
mikedeshazer opened this issue Nov 28, 2019 · 5 comments
Closed

Oracle Contracts for Testnets (Rinkeby & Kovan) #3

mikedeshazer opened this issue Nov 28, 2019 · 5 comments

Comments

@mikedeshazer
Copy link
Member

mikedeshazer commented Nov 28, 2019

There have been a few requests for the OrFeed Oracle to be used and tested in testnet environments.

This will require the default tokens (about 15 or, such as SAI, DAI, LINK, CDAI etc) to have addresses updated for the testnets, as well as Synths such as USD, JPY etc in the main contacts (contracts/orfeed.sol and draftpremium.sol) so it can have the same functionality as the main contract.

To solve this, we will need a pull request into the develop branch for new folders in the contracts folders for kovan and rinkeby with the appropriate orfeed.sol contract.
Please verify the contract on Etherscan so it can be tested on etherscan/dapp site.
Additionally, please update the README to have support for instructions on the testnets.

@mikedeshazer mikedeshazer changed the title Testnet (Rinkeby & Kovan) Oracle Contracts for Testnets (Rinkeby & Kovan) Nov 28, 2019
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 1.0 ETH (152.24 USD @ $152.24/ETH) attached to it as part of the ProofSuite fund.

@gitcoinbot
Copy link

gitcoinbot commented Nov 28, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 4 weeks, 1 day from now.
Please review their action plans below:

1) mul1sh has started work.

I will go through all the tokens and integrate them into the testnets as required.
2) thach4567 has started work.

I understand the requirements and do the work rightaway after submit plan.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 1.0 ETH (152.01 USD @ $152.01/ETH) attached to this issue has been approved & issued to @thach4567.

@mikedeshazer
Copy link
Member Author

Issue is allegedly solved. Will create another issue for tests. Testnet addresses are at the bottom. @mul1sh, let me know if this doesn't work on your end. I don't know if Synths work properly (USD, EUR, etc)... or just share your telegram ID and we can chat about it.

@mul1sh
Copy link

mul1sh commented Nov 29, 2019

@mikedeshazer sure no worries, my telegram id is @mulilin, we can chat more there. Thanks 🙂

mikedeshazer added a commit that referenced this issue Nov 29, 2019
Merge pull request #8 from mikedeshazer/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants