This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Throw NotFoundHttpException when debug is disabled #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw NotFoundHttpException when debug is disabled and pass string in URL for example `http://site.com/user/1844379023` work find but `http://site.com/user/test` throw InvalidArgumentException
Propaganistas
suggested changes
Apr 10, 2017
src/FakeIdServiceProvider.php
Outdated
| try { | ||
| $value = $this->container->make('fakeid')->decode($value); | ||
| } catch (\InvalidArgumentException $e) { | ||
| throw config('app.debug') ? new \InvalidArgumentException($e->getMessage()) : new NotFoundHttpException; |
There was a problem hiding this comment.
No need to reconstruct an InvalidArgumentException. Just rethrow $e:
throw config('app.debug') ? $e : new NotFoundHttpException;
Propaganistas
approved these changes
Apr 11, 2017
|
The tests are failing. Please fix and also revert the tests file structure & Route facade use. |
|
Thanks. A new release has been tagged: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw NotFoundHttpException when debug is disabled and pass string in
URL
for example
http://site.com/user/1844379023work fine buthttp://site.com/user/testthrow InvalidArgumentException