Skip to content

Commit

Permalink
Add net6.0 compatibility
Browse files Browse the repository at this point in the history
  • Loading branch information
ProphetLamb committed Oct 14, 2023
1 parent 97a0078 commit 67d052b
Show file tree
Hide file tree
Showing 13 changed files with 26 additions and 17 deletions.
2 changes: 1 addition & 1 deletion examples/RedditDotnetScraper/RedditDotnetScraper.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Web">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFrameworks>net7.0;;net6.0</TargetFrameworks>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/ScrapeAAS.AngleSharp/ScrapeAAS.AngleSharp.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</PropertyGroup>

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFrameworks>net7.0;;net6.0</TargetFrameworks>

<RootNamespace>ScrapeAAS</RootNamespace>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/ScrapeAAS.Contracts/ScrapeAAS.Contracts.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFrameworks>net7.0;;net6.0</TargetFrameworks>

<RootNamespace>ScrapeAAS</RootNamespace>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/ScrapeAAS.HttpClient/ScrapeAAS.HttpClient.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
</PropertyGroup>

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFrameworks>net7.0;;net6.0</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/ScrapeAAS.InMemory/ScrapeAAS.InMemory.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFrameworks>net7.0;;net6.0</TargetFrameworks>

<RootNamespace>ScrapeAAS</RootNamespace>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/ScrapeAAS.MessagePipe/ScrapeAAS.MessagePipe.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFrameworks>net7.0;;net6.0</TargetFrameworks>

<RootNamespace>ScrapeAAS</RootNamespace>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/ScrapeAAS.Polly/ScrapeAAS.Polly.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
</PropertyGroup>

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFrameworks>net7.0;;net6.0</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand Down
13 changes: 12 additions & 1 deletion src/ScrapeAAS.PuppeteerSharp/PuppeteerPageLoader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,13 @@ public ValueTask<IPage> GetPageAsync(CancellationToken cancellationToken = defau

private void CheckDisposedOrStarted()
{
#if NET7_0_OR_GREATER
ObjectDisposedException.ThrowIf(_disposed, this);

#else
if (_disposed) {
throw new ObjectDisposedException(this.GetType().FullName);
}
#endif
if (_operationStarted)
{
throw new InvalidOperationException("The handler has already started one or more requests. Properties can only be modified before sending the first request.");
Expand All @@ -249,7 +254,13 @@ private void CheckDisposedOrStarted()
[MemberNotNull(nameof(_innerHandler))]
private void SetOperationStarted()
{
#if NET7_0_OR_GREATER
ObjectDisposedException.ThrowIf(_disposed, this);
#else
if (_disposed) {
throw new ObjectDisposedException(this.GetType().FullName);
}
#endif

if (_innerHandler is null)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
</PropertyGroup>

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFrameworks>net7.0;;net6.0</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/ScrapeAAS.WebShare/ScrapeAAS.WebShare.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFrameworks>net7.0;;net6.0</TargetFrameworks>

<RootNamespace>ScrapeAAS</RootNamespace>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/ScrapeAAS/ScrapeAAS.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
</ItemGroup>

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFrameworks>net7.0;;net6.0</TargetFrameworks>
</PropertyGroup>


Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFrameworks>net7.0;;net6.0</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>

Expand All @@ -22,8 +22,7 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\..\src\ScrapeAAS.MessagePipe\ScrapeAAS.MessagePipe.csproj" />
<ProjectReference Include="..\..\src\ScrapeAAS.InMemory\ScrapeAAS.InMemory.csproj" />
<ProjectReference Include="..\..\src\ScrapeAAS\ScrapeAAS.csproj" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFrameworks>net7.0;;net6.0</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>

Expand All @@ -21,8 +21,7 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\..\src\ScrapeAAS.PuppeteerSharp\ScrapeAAS.PuppeteerSharp.csproj" />
<ProjectReference Include="..\..\src\ScrapeAAS.InMemory\ScrapeAAS.InMemory.csproj" />
<ProjectReference Include="..\..\src\ScrapeAAS\ScrapeAAS.csproj" />
</ItemGroup>

</Project>

0 comments on commit 67d052b

Please sign in to comment.