account for possible step application failure during rebase #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @marijnh 馃憢
we intermittently see steps which can be applied cleanly locally, but induce an error when rebased on top of remote confirmed steps.
i am aware that
maybeStep()
possibly throwing is by design. locally i'm seeing desirable behavior with the patch here, which simply ignores the failed steps altogether.things i'm unsure of:
i haven't been able to isolate a simplified repro case for this error yet but i'm happy to describe the scenario in more detail if it would be helpful. the short version is (unsurprisingly), 'its complicated' 馃檭
fwiw, with the same code, we're seeing this error orders of magnitude more frequently in prosemirror-transform@1.8.0 than prosemirror-transform@1.4.2